Commit 16be9a16 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

ethernet: use eth_hw_addr_set() - casts 



eth_hw_addr_set() takes a u8 pointer, like other
etherdevice helpers. Convert the few drivers which
require casts because they memcpy from "endian marked"
types.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4d3d2c8d

drivers/net/ethernet/3com/3c509.c

+1 −1
Original line number Diff line number Diff line
@@ -270,7 +270,7 @@ static void el3_dev_fill(struct net_device *dev, __be16 *phys_addr, int ioaddr, 
{

	struct el3_private *lp = netdev_priv(dev);



	memcpy(dev->dev_addr, phys_addr, ETH_ALEN);

	eth_hw_addr_set(dev, (u8 *)phys_addr);

	dev->base_addr = ioaddr;

	dev->irq = irq;

	dev->if_port = if_port;

drivers/net/ethernet/cortina/gemini.c

+1 −1
Original line number Diff line number Diff line
@@ -2467,7 +2467,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev) 
		       DEFAULT_NAPI_WEIGHT);



	if (is_valid_ether_addr((void *)port->mac_addr)) {

		memcpy(netdev->dev_addr, port->mac_addr, ETH_ALEN);

		eth_hw_addr_set(netdev, (u8 *)port->mac_addr);

	} else {

		dev_dbg(dev, "ethernet address 0x%08x%08x%08x invalid\n",

			port->mac_addr[0], port->mac_addr[1],

drivers/net/ethernet/intel/e100.c

+1 −1
Original line number Diff line number Diff line
@@ -2921,7 +2921,7 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	e100_phy_init(nic);



	memcpy(netdev->dev_addr, nic->eeprom, ETH_ALEN);

	eth_hw_addr_set(netdev, (u8 *)nic->eeprom);

	if (!is_valid_ether_addr(netdev->dev_addr)) {

		if (!eeprom_bad_csum_allow) {

			netif_err(nic, probe, nic->netdev, "Invalid MAC address from EEPROM, aborting\n");