Commit 169345d4 authored by Joe Perches's avatar Joe Perches Committed by Kalle Valo
Browse files

ath6kl: add __printf verification to ath6kl_dbg 



Fix fallout too.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarSteve deRosier <derosier@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 37ff1b0d

drivers/net/wireless/ath/ath6kl/debug.h

+2 −0
Original line number Diff line number Diff line
@@ -63,6 +63,7 @@ int ath6kl_read_tgt_stats(struct ath6kl *ar, struct ath6kl_vif *vif); 


#ifdef CONFIG_ATH6KL_DEBUG



__printf(2, 3)

void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...);

void ath6kl_dbg_dump(enum ATH6K_DEBUG_MASK mask,

		     const char *msg, const char *prefix,
@@ -83,6 +84,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar); 
void ath6kl_debug_cleanup(struct ath6kl *ar);



#else

__printf(2, 3)

static inline void ath6kl_dbg(enum ATH6K_DEBUG_MASK dbg_mask,

			      const char *fmt, ...)

{

drivers/net/wireless/ath/ath6kl/htc_pipe.c

+1 −1
Original line number Diff line number Diff line
@@ -995,7 +995,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb, 


	if (netlen < (payload_len + HTC_HDR_LENGTH)) {

		ath6kl_dbg(ATH6KL_DBG_HTC,

			   "HTC Rx: insufficient length, got:%d expected =%u\n",

			   "HTC Rx: insufficient length, got:%d expected =%zu\n",

			   netlen, payload_len + HTC_HDR_LENGTH);

		status = -EINVAL;

		goto free_skb;

drivers/net/wireless/ath/ath6kl/wmi.c

+1 −1
Original line number Diff line number Diff line
@@ -1596,7 +1596,7 @@ static int ath6kl_wmi_txe_notify_event_rx(struct wmi *wmi, u8 *datap, int len, 
	rate = le32_to_cpu(ev->rate);

	pkts = le32_to_cpu(ev->pkts);



	ath6kl_dbg(ATH6KL_DBG_WMI, "TXE notify event: peer %pM rate %d% pkts %d intvl %ds\n",

	ath6kl_dbg(ATH6KL_DBG_WMI, "TXE notify event: peer %pM rate %d%% pkts %d intvl %ds\n",

		   vif->bssid, rate, pkts, vif->txe_intvl);



	cfg80211_cqm_txe_notify(vif->ndev, vif->bssid, pkts,