Commit 167b3f2d authored by Valentina Goncharenko's avatar Valentina Goncharenko Committed by David S. Miller
Browse files

net: encx24j600: Add parentheses to fix precedence 



In functions regmap_encx24j600_phy_reg_read() and
regmap_encx24j600_phy_reg_write() in the conditions of the waiting
cycles for filling the variable 'ret' it is necessary to add parentheses
to prevent wrong assignment due to logical operations precedence.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d70e5326 ("net: Microchip encx24j600 driver")
Signed-off-by: default avatarValentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5c306de8

drivers/net/ethernet/microchip/encx24j600-regmap.c

+2 −2
Original line number Diff line number Diff line
@@ -359,7 +359,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg, 
		goto err_out;



	usleep_range(26, 100);

	while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&

	while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&

	       (mistat & BUSY))

		cpu_relax();
@@ -397,7 +397,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg, 
		goto err_out;



	usleep_range(26, 100);

	while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&

	while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&

	       (mistat & BUSY))

		cpu_relax();