Commit 1670e678 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Miquel Raynal
Browse files

mtd: rawnand: ingenic: Add of_node_put() before return 



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 60be51f4

drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c

+1 −0
Original line number Diff line number Diff line
@@ -418,6 +418,7 @@ static int ingenic_nand_init_chips(struct ingenic_nfc *nfc, 
		ret = ingenic_nand_init_chip(pdev, nfc, np, i);

		if (ret) {

			ingenic_nand_cleanup_chips(nfc);

			of_node_put(np);

			return ret;

		}