Commit 166d74b8 authored Jul 12, 2022 by Nilesh Javali Committed by Martin K. Petersen Jul 18, 2022

scsi: qla2xxx: Fix sparse warning for dport_data

Use le16_to_cpu to fix sparse warning reported for dport_data.

sparse warnings: (new ones prefixed by >>)
>> drivers/scsi/qla2xxx/qla_bsg.c:2485:34: sparse: sparse: incorrect
>> type in assignment (different base types) @@ expected unsigned
>> short [usertype] mbx1 @@ got restricted __le16 @@
   drivers/scsi/qla2xxx/qla_bsg.c:2485:34: sparse: expected unsigned short [usertype] mbx1
      drivers/scsi/qla2xxx/qla_bsg.c:2485:34: sparse: got restricted __le16
>> drivers/scsi/qla2xxx/qla_bsg.c:2486:34: sparse: sparse:
>> incorrect type in assignment (different base types) @@
>> expected unsigned short [usertype] mbx2 @@ got restricted __le16 @@
   drivers/scsi/qla2xxx/qla_bsg.c:2486:34: sparse: expected unsigned short [usertype] mbx2
   drivers/scsi/qla2xxx/qla_bsg.c:2486:34: sparse: got restricted __le16

Link: https://lore.kernel.org/r/20220713052045.10683-9-njavali@marvell.com


Fixes: 476da8fa ("scsi: qla2xxx: Add a new v2 dport diagnostic feature")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 47ccb113

drivers/scsi/qla2xxx/qla_bsg.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2482,8 +2482,8 @@ qla2x00_do_dport_diagnostics_v2(struct bsg_job *bsg_job)
	dd->mbx2 = mcp->mb[1];		dd->mbx2 = mcp->mb[1];
	vha->dport_status \|= DPORT_DIAG_IN_PROGRESS;		vha->dport_status \|= DPORT_DIAG_IN_PROGRESS;
	} else if (options == QLA_GET_DPORT_RESULT_V2) {		} else if (options == QLA_GET_DPORT_RESULT_V2) {
	dd->mbx1 = vha->dport_data[1];		dd->mbx1 = le16_to_cpu(vha->dport_data[1]);
	dd->mbx2 = vha->dport_data[2];		dd->mbx2 = le16_to_cpu(vha->dport_data[2]);
	}		}
	} else {		} else {
	dd->mbx1 = mcp->mb[0];		dd->mbx1 = mcp->mb[0];