Commit 16484413 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller
Browse files

net: dsa: microchip: ksz8795: Fix VLAN filtering 



Currently ksz8_port_vlan_filtering() sets or clears the VLAN Enable
hardware flag.  That controls discarding of packets with a VID that
has not been enabled for any port on the switch.

Since it is a global flag, set the dsa_switch::vlan_filtering_is_global
flag so that the DSA core understands this can't be controlled per
port.

When VLAN filtering is enabled, the switch should also discard packets
with a VID that's not enabled on the ingress port.  Set or clear each
external port's VLAN Ingress Filter flag in ksz8_port_vlan_filtering()
to make that happen.

Fixes: e66f840c ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
Signed-off-by: default avatarBen Hutchings <ben.hutchings@mind.be>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9130c2d3

drivers/net/dsa/microchip/ksz8795.c

+11 −0
Original line number Diff line number Diff line
@@ -1119,8 +1119,14 @@ static int ksz8_port_vlan_filtering(struct dsa_switch *ds, int port, bool flag, 
	if (ksz_is_ksz88x3(dev))

		return -ENOTSUPP;



	/* Discard packets with VID not enabled on the switch */

	ksz_cfg(dev, S_MIRROR_CTRL, SW_VLAN_ENABLE, flag);



	/* Discard packets with VID not enabled on the ingress port */

	for (port = 0; port < dev->phy_port_cnt; ++port)

		ksz_port_cfg(dev, port, REG_PORT_CTRL_2, PORT_INGRESS_FILTER,

			     flag);



	return 0;

}
@@ -1758,6 +1764,11 @@ static int ksz8_switch_init(struct ksz_device *dev) 
	 */

	dev->ds->untag_bridge_pvid = true;



	/* VLAN filtering is partly controlled by the global VLAN

	 * Enable flag

	 */

	dev->ds->vlan_filtering_is_global = true;



	return 0;

}