Unverified Commit 16255d41 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: codecs: rt1019: clarify expression 



cppcheck warning, add parentheses:

sound/soc/codecs/rt1019.c:375:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT |
                                                            ^

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210426214701.235106-4-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d51f6dfb

sound/soc/codecs/rt1019.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -372,8 +372,8 @@ static int rt1019_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source, 
		RT1019_AUTO_BITS_SEL_MANU | RT1019_AUTO_CLK_SEL_MANU);

		RT1019_AUTO_BITS_SEL_MANU | RT1019_AUTO_CLK_SEL_MANU);

	snd_soc_component_update_bits(component, RT1019_PLL_1,

	snd_soc_component_update_bits(component, RT1019_PLL_1,

		RT1019_PLL_M_MASK | RT1019_PLL_M_BP_MASK | RT1019_PLL_Q_8_8_MASK,

		RT1019_PLL_M_MASK | RT1019_PLL_M_BP_MASK | RT1019_PLL_Q_8_8_MASK,

		(pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT |

		((pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT) |

		pll_code.m_bp << RT1019_PLL_M_BP_SFT |

		(pll_code.m_bp << RT1019_PLL_M_BP_SFT) |

		((pll_code.n_code >> 8) & RT1019_PLL_Q_8_8_MASK));

		((pll_code.n_code >> 8) & RT1019_PLL_Q_8_8_MASK));

	snd_soc_component_update_bits(component, RT1019_PLL_2,

	snd_soc_component_update_bits(component, RT1019_PLL_2,

		RT1019_PLL_Q_7_0_MASK, pll_code.n_code & RT1019_PLL_Q_7_0_MASK);

		RT1019_PLL_Q_7_0_MASK, pll_code.n_code & RT1019_PLL_Q_7_0_MASK);