Commit 160d6e40 authored Jul 14, 2022 by Kent Gibson Committed by Bartosz Golaszewski Jul 19, 2022

gpiolib: cdev: simplify linereq_free



The edge detector is only ever started after the line desc has been
determined, so move edge_detector_stop() inside the line desc check,
and merge the two checked regions into one.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Dipen Patel <dipenp@nvidia.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

parent 3e2d53b2

drivers/gpio/gpiolib-cdev.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1460,16 +1460,16 @@ static ssize_t linereq_read(struct file *file,
		static void linereq_free(struct linereq *lr)
		{
		unsigned int i;
		bool hte = false;
		bool hte;

		for (i = 0; i < lr->num_lines; i++) {
		if (lr->lines[i].desc)
		if (lr->lines[i].desc) {
		hte = !!test_bit(FLAG_EVENT_CLOCK_HTE,
		&lr->lines[i].desc->flags);
		edge_detector_stop(&lr->lines[i], hte);
		if (lr->lines[i].desc)
		gpiod_free(lr->lines[i].desc);
		}
		}
		kfifo_free(&lr->events);
		kfree(lr->label);
		put_device(&lr->gdev->dev);