Commit 15ff9e7f authored by Yunfei Dong's avatar Yunfei Dong Committed by Mauro Carvalho Chehab
Browse files

media: mediatek: vcodec: Avoid unneeded error logging 



Since the LAT decoder works faster than its CORE, getting the trans
buffer may be done only after CORE finishes processing: avoid printing
an error if the decode function returns -EAGAIN, as this means that
the buffer from CORE is not yet available, but will be at a later time.

Also change the log level for calls to vdec_msg_queue_dqbuf() in H264
and VP9 LAT decoder drivers to avoid excessive logging.

Signed-off-by: default avatarYunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 2f16c95e

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateless.c

+1 −1
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static void mtk_vdec_worker(struct work_struct *work) 
		mtk_v4l2_err("vb2 buffer media request is NULL");



	ret = vdec_if_decode(ctx, bs_src, NULL, &res_chg);

	if (ret) {

	if (ret && ret != -EAGAIN) {

		mtk_v4l2_err(" <===[%d], src_buf[%d] sz=0x%zx pts=%llu vdec_if_decode() ret=%d res_chg=%d===>",

			     ctx->id, vb2_src->index, bs_src->size,

			     vb2_src->timestamp, ret, res_chg);

drivers/media/platform/mediatek/vcodec/vdec/vdec_h264_req_multi_if.c

+1 −1
Original line number Diff line number Diff line
@@ -596,7 +596,7 @@ static int vdec_h264_slice_lat_decode(void *h_vdec, struct mtk_vcodec_mem *bs, 


	lat_buf = vdec_msg_queue_dqbuf(&inst->ctx->msg_queue.lat_ctx);

	if (!lat_buf) {

		mtk_vcodec_err(inst, "failed to get lat buffer");

		mtk_vcodec_debug(inst, "failed to get lat buffer");

		return -EAGAIN;

	}

	share_info = lat_buf->private_data;

drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c

+1 −1
Original line number Diff line number Diff line
@@ -2069,7 +2069,7 @@ static int vdec_vp9_slice_lat_decode(void *h_vdec, struct mtk_vcodec_mem *bs, 


	lat_buf = vdec_msg_queue_dqbuf(&instance->ctx->msg_queue.lat_ctx);

	if (!lat_buf) {

		mtk_vcodec_err(instance, "Failed to get VP9 lat buf\n");

		mtk_vcodec_debug(instance, "Failed to get VP9 lat buf\n");

		return -EAGAIN;

	}

	pfc = (struct vdec_vp9_slice_pfc *)lat_buf->private_data;