Commit 15f242bb authored by Hugh Dickins's avatar Hugh Dickins Committed by Andrew Morton
Browse files

mm/shmem: tmpfs fallocate use file_modified() 

5.18 fixed the btrfs and ext4 fallocates to use file_modified(), as xfs
was already doing, to drop privileges: and fstests generic/{683,684,688}
expect this.  There's no need to argue over keep-size allocation (which
could just update ctime): fix shmem_fallocate() to behave the same way.

Link: https://lkml.kernel.org/r/39c5e62-4896-7795-c0a0-f79c50d4909@google.com


Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Acked-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Radoslaw Burny <rburny@google.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent cb241339

mm/shmem.c

+2 −1
Original line number Diff line number Diff line
@@ -2839,12 +2839,13 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset, 


	if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + len > inode->i_size)

		i_size_write(inode, offset + len);

	inode->i_ctime = current_time(inode);

undone:

	spin_lock(&inode->i_lock);

	inode->i_private = NULL;

	spin_unlock(&inode->i_lock);

out:

	if (!error)

		file_modified(file);

	inode_unlock(inode);

	return error;

}