Commit 15d221d0 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller
Browse files

hinic: Avoid some over memory allocation 



'prod_idx' (atomic_t) is larger than 'shadow_idx' (u16), so some memory is
over-allocated.

Fixes: b15a9f37 ("net-next/hinic: Add wq")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 43252ed1

drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c

+1 −1
Original line number Diff line number Diff line
@@ -386,7 +386,7 @@ static int alloc_wqes_shadow(struct hinic_wq *wq) 
		return -ENOMEM;



	wq->shadow_idx = devm_kcalloc(&pdev->dev, wq->num_q_pages,

				      sizeof(wq->prod_idx), GFP_KERNEL);

				      sizeof(*wq->shadow_idx), GFP_KERNEL);

	if (!wq->shadow_idx)

		goto err_shadow_idx;