Commit 1599069a authored by Jules Maselbas's avatar Jules Maselbas Committed by Vinod Koul
Browse files

phy: core: Warn when phy_power_on is called before phy_init 



A warning when the order of phy operation is mixed up by drivers,
this is an atempt to make the phy usage more uniform across (usb)
drivers.

Signed-off-by: default avatarJules Maselbas <jmaselbas@kalray.eu>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Link: https://lore.kernel.org/r/20220407102108.24211-4-jmaselbas@kalray.eu


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent bd5bd02e

drivers/phy/phy-core.c

+3 −0
Original line number Diff line number Diff line
@@ -253,6 +253,9 @@ int phy_init(struct phy *phy) 
	ret = 0; /* Override possible ret == -ENOTSUPP */



	mutex_lock(&phy->mutex);

	if (phy->power_count > phy->init_count)

		dev_warn(&phy->dev, "phy_power_on was called before phy_init\n");



	if (phy->init_count == 0 && phy->ops->init) {

		ret = phy->ops->init(phy);

		if (ret < 0) {