Commit 1573c688 authored by Po-Hsu Lin's avatar Po-Hsu Lin Committed by David S. Miller
Browse files

selftests: net: fix cmsg_so_mark.sh test hang 

This cmsg_so_mark.sh test will hang on non-amd64 systems because of the
infinity loop for argument parsing in cmsg_sender.

Variable "o" in cs_parse_args() for taking getopt() should be an int,
otherwise it will be 255 when getopt() returns -1 on non-amd64 system
and thus causing infinity loop.

Link: https://lore.kernel.org/lkml/CA+G9fYsM2k7mrF7W4V_TrZ-qDauWM394=8yEJ=-t1oUg8_40YA@mail.gmail.com/t/


Signed-off-by: default avatarPo-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a512807c

tools/testing/selftests/net/cmsg_sender.c

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static void __attribute__((noreturn)) cs_usage(const char *bin) 


static void cs_parse_args(int argc, char *argv[])

{

	char o;

	int o;



	while ((o = getopt(argc, argv, "46sS:p:m:M:d:tf:F:c:C:l:L:H:")) != -1) {

		switch (o) {