Commit 154036a3 authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Vlastimil Babka
Browse files

mm: slab: fix comment for __assume_kmalloc_alignment 



The comment next to the __assume_kmalloc_alignment definition is not
precise: kmalloc relies on kmem_cache_alloc, so kmalloc technically returns
pointers aligned to both ARCH_KMALLOC_MINALIGN and ARCH_SLAB_MINALIGN,
not only to ARCH_KMALLOC_MINALIGN.

(See create_kmalloc_cache()->create_boot_cache()->calculate_alignment()
 for SLAB and SLUB and __do_kmalloc_node() for SLOB.)

Clarify the comment.

The assumption specified by __assume_kmalloc_alignment is still correct,
although it can be made stronger. I'll leave this to a separate patch.

Signed-off-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Link: https://lore.kernel.org/r/84d8142747230f2015eaf9705ee7c2e1a9f56596.1651161548.git.andreyknvl@google.com
parent 8cf9e121

include/linux/slab.h

+3 −3
Original line number Diff line number Diff line
@@ -217,9 +217,9 @@ void kmem_dump_obj(void *object); 
#endif



/*

 * kmalloc and friends return ARCH_KMALLOC_MINALIGN aligned

 * pointers. kmem_cache_alloc and friends return ARCH_SLAB_MINALIGN

 * aligned pointers.

 * kmem_cache_alloc and friends return pointers aligned to ARCH_SLAB_MINALIGN.

 * kmalloc and friends return pointers aligned to both ARCH_KMALLOC_MINALIGN

 * and ARCH_SLAB_MINALIGN, but here we only assume the former alignment.

 */

#define __assume_kmalloc_alignment __assume_aligned(ARCH_KMALLOC_MINALIGN)

#define __assume_slab_alignment __assume_aligned(ARCH_SLAB_MINALIGN)