Commit 14f8c55d authored by Yang Yingliang's avatar Yang Yingliang Committed by Lee Jones
Browse files

mfd: pm8008: Fix return value check in pm8008_probe() 



In case of error, the function devm_regmap_init_i2c() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 6b149f33 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: default avatarGuru Das Srinagesh <gurus@codeaurora.org>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221125073626.1868229-1-yangyingliang@huawei.com
parent cb83cb0d

drivers/mfd/qcom-pm8008.c

+2 −2
Original line number Diff line number Diff line
@@ -215,8 +215,8 @@ static int pm8008_probe(struct i2c_client *client) 


	dev = &client->dev;

	regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);

	if (!regmap)

		return -ENODEV;

	if (IS_ERR(regmap))

		return PTR_ERR(regmap);



	i2c_set_clientdata(client, regmap);