Commit 14ee45b7 authored by Chuck Lever's avatar Chuck Lever
Browse files

NFSD: Avoid calling fh_drop_write() twice in do_nfsd_create() 



Clean up: The "out" label already invokes fh_drop_write().

Note that fh_drop_write() is already careful not to invoke
mnt_drop_write() if either it has already been done or there is
nothing to drop. Therefore no change in behavior is expected.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent e6156859

fs/nfsd/vfs.c

+1 −4
Original line number Diff line number Diff line
@@ -1479,7 +1479,6 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, 
		case NFS3_CREATE_GUARDED:

			err = nfserr_exist;

		}

		fh_drop_write(fhp);

		goto out;

	}
@@ -1487,10 +1486,8 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, 
		iap->ia_mode &= ~current_umask();



	host_err = vfs_create(&init_user_ns, dirp, dchild, iap->ia_mode, true);

	if (host_err < 0) {

		fh_drop_write(fhp);

	if (host_err < 0)

		goto out_nfserr;

	}

	if (created)

		*created = true;