Commit 14eddb0f authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: cleanup isys_irq headers 



Don't need to declare those functions with extern:
	drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h:51:35:  warning: function 'isys_irqc_state_dump' with external linkage has definition
	drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h:68:35:  warning: function 'isys_irqc_reg_store' with external linkage has definition
	drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h:85:39:  warning: function 'isys_irqc_reg_load' with external linkage has definition
	drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq.c:31:35:  warning: function 'isys_irqc_status_enable' with external linkage has definition

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent c5ea3e43

drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq.c

+1 −2
Original line number Diff line number Diff line
@@ -28,8 +28,7 @@ 
#endif



/* Public interface */

STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_status_enable(

    const isys_irq_ID_t	isys_irqc_id)

void isys_irqc_status_enable(const isys_irq_ID_t	isys_irqc_id)

{

	assert(isys_irqc_id < N_ISYS_IRQ_ID);

drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h

+4 −4
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ 
* @brief Get the isys irq status.

* Refer to "isys_irq.h" for details.

*/

STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_state_get(

void isys_irqc_state_get(

    const isys_irq_ID_t	isys_irqc_id,

    isys_irqc_state_t *state)

{
@@ -48,7 +48,7 @@ STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_state_get( 
* @brief Dump the isys irq status.

* Refer to "isys_irq.h" for details.

*/

STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_state_dump(

void isys_irqc_state_dump(

    const isys_irq_ID_t	isys_irqc_id,

    const isys_irqc_state_t *state)

{
@@ -65,7 +65,7 @@ STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_state_dump( 
 + -------------------------------------------------------*/



/* Support functions */

STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_reg_store(

void isys_irqc_reg_store(

    const isys_irq_ID_t	isys_irqc_id,

    const unsigned int	reg_idx,

    const hrt_data	value)
@@ -82,7 +82,7 @@ STORAGE_CLASS_ISYS2401_IRQ_C void isys_irqc_reg_store( 
	ia_css_device_store_uint32(reg_addr, value);

}



STORAGE_CLASS_ISYS2401_IRQ_C hrt_data isys_irqc_reg_load(

hrt_data isys_irqc_reg_load(

    const isys_irq_ID_t	isys_irqc_id,

    const unsigned int	reg_idx)

{

drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_irq_public.h

+10 −15
Original line number Diff line number Diff line
@@ -21,25 +21,20 @@ 


#if defined(ISP2401)



STORAGE_CLASS_ISYS2401_IRQ_H void isys_irqc_state_get(

    const isys_irq_ID_t	isys_irqc_id,

void isys_irqc_state_get(const isys_irq_ID_t	isys_irqc_id,

			 isys_irqc_state_t	*state);



STORAGE_CLASS_ISYS2401_IRQ_H void isys_irqc_state_dump(

    const isys_irq_ID_t	isys_irqc_id,

void isys_irqc_state_dump(const isys_irq_ID_t	isys_irqc_id,

			  const isys_irqc_state_t *state);



STORAGE_CLASS_ISYS2401_IRQ_H void isys_irqc_reg_store(

    const isys_irq_ID_t	isys_irqc_id,

void isys_irqc_reg_store(const isys_irq_ID_t	isys_irqc_id,

			 const unsigned int	reg_idx,

			 const hrt_data		value);



STORAGE_CLASS_ISYS2401_IRQ_H hrt_data isys_irqc_reg_load(

    const isys_irq_ID_t	isys_irqc_id,

hrt_data isys_irqc_reg_load(const isys_irq_ID_t	isys_irqc_id,

			    const unsigned int	reg_idx);



STORAGE_CLASS_ISYS2401_IRQ_H void isys_irqc_status_enable(

    const isys_irq_ID_t	isys_irqc_id);

void isys_irqc_status_enable(const isys_irq_ID_t isys_irqc_id);



#endif /* defined(ISP2401) */

drivers/staging/media/atomisp/pci/hive_isp_css_include/isys_irq.h

+0 −12
Original line number Diff line number Diff line
@@ -21,20 +21,8 @@ 


#if defined(ISP2401)



#ifndef __INLINE_ISYS2401_IRQ__



#define STORAGE_CLASS_ISYS2401_IRQ_H extern

#define STORAGE_CLASS_ISYS2401_IRQ_C extern

#include "isys_irq_public.h"



#else  /* __INLINE_ISYS2401_IRQ__ */



#define STORAGE_CLASS_ISYS2401_IRQ_H static inline

#define STORAGE_CLASS_ISYS2401_IRQ_C static inline

#include "isys_irq_private.h"



#endif /* __INLINE_ISYS2401_IRQ__ */



#endif /* defined(ISP2401) */



#endif	/* __IA_CSS_ISYS_IRQ_H__ */