Commit 14cf45f2 authored by Patrick Rudolph's avatar Patrick Rudolph Committed by Guenter Roeck
Browse files

hwmon: pmbus: Reduce clear fault page invocations 



Observing I2C traffic revealed consecutive transmission of CLEAR_FAULT
commands. While this doesn't cause issues, it extends driver probe time.

Avoid invoking pmbus_clear_fault_page for virtual registers, as they're
managed by the driver, not the chip.

TEST: Verified using an I2C bus analyzer that only one CLEAR_FAULT
      command is send instead 5 in a row.

Signed-off-by: default avatarPatrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: default avatarNaresh Solanki <Naresh.Solanki@9elements.com>
Link: https://lore.kernel.org/r/20230817092527.808631-1-Naresh.Solanki@9elements.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 7d9be29d

drivers/hwmon/pmbus/pmbus_core.c

+2 −1
Original line number Diff line number Diff line
@@ -561,6 +561,7 @@ static bool pmbus_check_register(struct i2c_client *client, 
		rv = pmbus_check_status_cml(client);

	if (rv < 0 && (data->flags & PMBUS_READ_STATUS_AFTER_FAILED_CHECK))

		data->read_status(client, -1);

	if (reg < PMBUS_VIRT_BASE)

		pmbus_clear_fault_page(client, -1);

	return rv >= 0;

}