Commit 14ad6647 authored by David S. Miller's avatar David S. Miller
Browse files

gen_stats: Stop using NLA_PUT*(). 



These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0e3cea7b

net/core/gen_stats.c

+2 −1
Original line number Diff line number Diff line
@@ -27,7 +27,8 @@ 
static inline int

gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)

{

	NLA_PUT(d->skb, type, size, buf);

	if (nla_put(d->skb, type, size, buf))

		goto nla_put_failure;

	return 0;



nla_put_failure: