Unverified Commit 147b5fff authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Mark Brown
Browse files

regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set 



Before adding support to define bulk read/write callbacks in regmap_config
by the commit d77e7456 ("regmap: Add bulk read/write callbacks into
regmap_config"), the regmap_noinc_read() function returned an errno early
a map->bus->read callback wasn't set.

But that commit dropped the check and now a call to _regmap_raw_read() is
attempted even when bulk read operations are not supported. That function
checks for map->read anyways but there's no point to continue if the read
can't succeed.

Also is a fragile assumption to make so is better to make it fail earlier.

Fixes: d77e7456 ("regmap: Add bulk read/write callbacks into regmap_config")
Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20220616073435.1988219-3-javierm@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b688a762

drivers/base/regmap/regmap.c

+3 −0
Original line number Diff line number Diff line
@@ -2904,6 +2904,9 @@ int regmap_noinc_read(struct regmap *map, unsigned int reg, 
	size_t read_len;

	int ret;



	if (!map->read)

		return -ENOTSUPP;



	if (val_len % map->format.val_bytes)

		return -EINVAL;

	if (!IS_ALIGNED(reg, map->reg_stride))