Commit 146a37e0 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Greg Kroah-Hartman
Browse files

serial: 8250: Fix serial8250_tx_empty() race with DMA Tx 



There's a potential race before THRE/TEMT deasserts when DMA Tx is
starting up (or the next batch of continuous Tx is being submitted).
This can lead to misdetecting Tx empty condition.

It is entirely normal for THRE/TEMT to be set for some time after the
DMA Tx had been setup in serial8250_tx_dma(). As Tx side is definitely
not empty at that point, it seems incorrect for serial8250_tx_empty()
claim Tx is empty.

Fix the race by also checking in serial8250_tx_empty() whether there's
DMA Tx active.

Note: This fix only addresses in-kernel race mainly to make using
TCSADRAIN/FLUSH robust. Userspace can still cause other races but they
seem userspace concurrency control problems.

Fixes: 9ee4b83e ("serial: 8250: Add support for dmaengine")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230317113318.31327-3-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 094fb49a

drivers/tty/serial/8250/8250.h

+12 −0
Original line number Diff line number Diff line
@@ -365,6 +365,13 @@ static inline void serial8250_do_prepare_rx_dma(struct uart_8250_port *p) 
	if (dma->prepare_rx_dma)

		dma->prepare_rx_dma(p);

}



static inline bool serial8250_tx_dma_running(struct uart_8250_port *p)

{

	struct uart_8250_dma *dma = p->dma;



	return dma && dma->tx_running;

}

#else

static inline int serial8250_tx_dma(struct uart_8250_port *p)

{
@@ -380,6 +387,11 @@ static inline int serial8250_request_dma(struct uart_8250_port *p) 
	return -1;

}

static inline void serial8250_release_dma(struct uart_8250_port *p) { }



static inline bool serial8250_tx_dma_running(struct uart_8250_port *p)

{

	return false;

}

#endif



static inline int ns16550a_goto_highspeed(struct uart_8250_port *up)

drivers/tty/serial/8250/8250_port.c

+4 −3
Original line number Diff line number Diff line
@@ -2005,18 +2005,19 @@ static int serial8250_tx_threshold_handle_irq(struct uart_port *port) 
static unsigned int serial8250_tx_empty(struct uart_port *port)

{

	struct uart_8250_port *up = up_to_u8250p(port);

	unsigned int result = 0;

	unsigned long flags;

	u16 lsr;



	serial8250_rpm_get(up);



	spin_lock_irqsave(&port->lock, flags);

	lsr = serial_lsr_in(up);

	if (!serial8250_tx_dma_running(up) && uart_lsr_tx_empty(serial_lsr_in(up)))

		result = TIOCSER_TEMT;

	spin_unlock_irqrestore(&port->lock, flags);



	serial8250_rpm_put(up);



	return uart_lsr_tx_empty(lsr) ? TIOCSER_TEMT : 0;

	return result;

}



unsigned int serial8250_do_get_mctrl(struct uart_port *port)