Commit 1469327b authored by Shang XiaoJing's avatar Shang XiaoJing Committed by Paolo Abeni
Browse files

ethernet: s2io: Use skb_put_data() instead of skb_put/memcpy pair 



Use skb_put_data() instead of skb_put() and memcpy(), which is shorter
and clear. Drop the tmp variable that is not needed any more.

Signed-off-by: default avatarShang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20220927022802.16050-1-shangxiaojing@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ceed40d7

drivers/net/ethernet/neterion/s2io.c

+1 −2
Original line number Diff line number Diff line
@@ -7359,10 +7359,9 @@ static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp) 
		int get_off = ring_data->rx_curr_get_info.offset;

		int buf0_len = RXD_GET_BUFFER0_SIZE_3(rxdp->Control_2);

		int buf2_len = RXD_GET_BUFFER2_SIZE_3(rxdp->Control_2);

		unsigned char *buff = skb_push(skb, buf0_len);



		struct buffAdd *ba = &ring_data->ba[get_block][get_off];

		memcpy(buff, ba->ba_0, buf0_len);

		skb_put_data(skb, ba->ba_0, buf0_len);

		skb_put(skb, buf2_len);

	}