Commit 14611b9b authored by Kalesh AP's avatar Kalesh AP Committed by Leon Romanovsky
Browse files

RDMA/bnxt_re: Remove unnecessary variable initializations 



Remove unnecessary variable initializations.

Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Link: https://lore.kernel.org/r/1691052326-32143-7-git-send-email-selvin.xavier@broadcom.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 00d0427f

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+7 −7
Original line number Diff line number Diff line
@@ -284,7 +284,7 @@ int bnxt_re_query_gid(struct ib_device *ibdev, u32 port_num, 
		      int index, union ib_gid *gid)

{

	struct bnxt_re_dev *rdev = to_bnxt_re_dev(ibdev, ibdev);

	int rc = 0;

	int rc;



	/* Ignore port_num */

	memset(gid, 0, sizeof(*gid));
@@ -684,7 +684,7 @@ int bnxt_re_destroy_ah(struct ib_ah *ib_ah, u32 flags) 
	struct bnxt_re_ah *ah = container_of(ib_ah, struct bnxt_re_ah, ib_ah);

	struct bnxt_re_dev *rdev = ah->rdev;

	bool block = true;

	int rc = 0;

	int rc;



	block = !(flags & RDMA_DESTROY_AH_SLEEPABLE);

	rc = bnxt_qplib_destroy_ah(&rdev->qplib_res, &ah->qplib_ah, block);
@@ -834,7 +834,7 @@ static int bnxt_re_destroy_gsi_sqp(struct bnxt_re_qp *qp) 
	struct bnxt_re_qp *gsi_sqp;

	struct bnxt_re_ah *gsi_sah;

	struct bnxt_re_dev *rdev;

	int rc = 0;

	int rc;



	rdev = qp->rdev;

	gsi_sqp = rdev->gsi_ctx.gsi_sqp;
@@ -1441,7 +1441,7 @@ static int bnxt_re_create_gsi_qp(struct bnxt_re_qp *qp, struct bnxt_re_pd *pd, 
{

	struct bnxt_re_dev *rdev;

	struct bnxt_qplib_qp *qplqp;

	int rc = 0;

	int rc;



	rdev = qp->rdev;

	qplqp = &qp->qplib_qp;
@@ -1872,7 +1872,7 @@ static int bnxt_re_modify_shadow_qp(struct bnxt_re_dev *rdev, 
				    int qp_attr_mask)

{

	struct bnxt_re_qp *qp = rdev->gsi_ctx.gsi_sqp;

	int rc = 0;

	int rc;



	if (qp_attr_mask & IB_QP_STATE) {

		qp->qplib_qp.modify_flags |= CMDQ_MODIFY_QP_MODIFY_MASK_STATE;
@@ -2222,7 +2222,7 @@ static int bnxt_re_build_qp1_send_v2(struct bnxt_re_qp *qp, 
	u8 ip_version = 0;

	u16 vlan_id = 0xFFFF;

	void *buf;

	int i, rc = 0;

	int i, rc;



	memset(&qp->qp1_hdr, 0, sizeof(qp->qp1_hdr));
@@ -3586,7 +3586,7 @@ static int send_phantom_wqe(struct bnxt_re_qp *qp) 
{

	struct bnxt_qplib_qp *lib_qp = &qp->qplib_qp;

	unsigned long flags;

	int rc = 0;

	int rc;



	spin_lock_irqsave(&qp->sq_lock, flags);

drivers/infiniband/hw/bnxt_re/main.c

+6 −6
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ static struct bnxt_ulp_ops bnxt_re_ulp_ops = { 
static int bnxt_re_register_netdev(struct bnxt_re_dev *rdev)

{

	struct bnxt_en_dev *en_dev;

	int rc = 0;

	int rc;



	en_dev = rdev->en_dev;
@@ -1145,7 +1145,7 @@ static int bnxt_re_alloc_res(struct bnxt_re_dev *rdev) 
{

	struct bnxt_re_ring_attr rattr = {};

	int num_vec_created = 0;

	int rc = 0, i;

	int rc, i;

	u8 type;



	/* Configure and allocate resources for qplib */
@@ -1343,7 +1343,7 @@ static void bnxt_re_query_hwrm_intf_version(struct bnxt_re_dev *rdev) 
	struct hwrm_ver_get_input req = {};

	struct bnxt_qplib_chip_ctx *cctx;

	struct bnxt_fw_msg fw_msg = {};

	int rc = 0;

	int rc;



	bnxt_re_init_hwrm_hdr((void *)&req, HWRM_VER_GET);

	req.hwrm_intf_maj = HWRM_VERSION_MAJOR;
@@ -1373,7 +1373,7 @@ static void bnxt_re_query_hwrm_intf_version(struct bnxt_re_dev *rdev) 


static int bnxt_re_ib_init(struct bnxt_re_dev *rdev)

{

	int rc = 0;

	int rc;

	u32 event;



	/* Register ib dev */
@@ -1613,7 +1613,7 @@ static int bnxt_re_add_device(struct auxiliary_device *adev, u8 wqe_mode) 
		container_of(adev, struct bnxt_aux_priv, aux_dev);

	struct bnxt_en_dev *en_dev;

	struct bnxt_re_dev *rdev;

	int rc = 0;

	int rc;



	/* en_dev should never be NULL as long as adev and aux_dev are valid. */

	en_dev = aux_priv->edev;
@@ -1859,7 +1859,7 @@ static struct auxiliary_driver bnxt_re_driver = { 


static int __init bnxt_re_mod_init(void)

{

	int rc = 0;

	int rc;



	pr_info("%s: %s", ROCE_DRV_MODULE_NAME, version);

	rc = auxiliary_driver_register(&bnxt_re_driver);

drivers/infiniband/hw/bnxt_re/qplib_fp.c

+3 −3
Original line number Diff line number Diff line
@@ -517,7 +517,7 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct bnxt_qplib_nq *nq, 
			 cqn_handler_t cqn_handler,

			 srqn_handler_t srqn_handler)

{

	int rc = -1;

	int rc;



	nq->pdev = pdev;

	nq->cqn_handler = cqn_handler;
@@ -712,7 +712,7 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res, 
	struct bnxt_qplib_rcfw_sbuf sbuf;

	struct creq_query_srq_resp_sb *sb;

	struct cmdq_query_srq req = {};

	int rc = 0;

	int rc;



	bnxt_qplib_rcfw_cmd_prep((struct cmdq_base *)&req,

				 CMDQ_BASE_OPCODE_QUERY_SRQ,
@@ -1354,7 +1354,7 @@ int bnxt_qplib_query_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp) 
	struct creq_query_qp_resp_sb *sb;

	struct cmdq_query_qp req = {};

	u32 temp32[4];

	int i, rc = 0;

	int i, rc;



	sbuf.size = ALIGN(sizeof(*sb), BNXT_QPLIB_CMDQE_UNITS);

	sbuf.sb = dma_alloc_coherent(&rcfw->pdev->dev, sbuf.size,

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

+1 −1
Original line number Diff line number Diff line
@@ -488,7 +488,7 @@ static int __bnxt_qplib_rcfw_send_message(struct bnxt_qplib_rcfw *rcfw, 
	struct bnxt_qplib_crsqe *crsqe;

	unsigned long flags;

	u16 cookie;

	int rc = 0;

	int rc;

	u8 opcode;



	opcode = __get_cmdq_base_opcode(msg->req, msg->req_sz);

drivers/infiniband/hw/bnxt_re/qplib_res.c

+4 −4
Original line number Diff line number Diff line
@@ -385,7 +385,7 @@ static int bnxt_qplib_alloc_tqm_rings(struct bnxt_qplib_res *res, 
	struct bnxt_qplib_hwq_attr hwq_attr = {};

	struct bnxt_qplib_sg_info sginfo = {};

	struct bnxt_qplib_tqm_ctx *tqmctx;

	int rc = 0;

	int rc;

	int i;



	tqmctx = &ctx->tqm_ctx;
@@ -463,7 +463,7 @@ static void bnxt_qplib_map_tqm_pgtbl(struct bnxt_qplib_tqm_ctx *ctx) 
static int bnxt_qplib_setup_tqm_rings(struct bnxt_qplib_res *res,

				      struct bnxt_qplib_ctx *ctx)

{

	int rc = 0;

	int rc;



	rc = bnxt_qplib_alloc_tqm_rings(res, ctx);

	if (rc)
@@ -501,7 +501,7 @@ int bnxt_qplib_alloc_ctx(struct bnxt_qplib_res *res, 
{

	struct bnxt_qplib_hwq_attr hwq_attr = {};

	struct bnxt_qplib_sg_info sginfo = {};

	int rc = 0;

	int rc;



	if (virt_fn || is_p5)

		goto stats_alloc;
@@ -876,7 +876,7 @@ int bnxt_qplib_alloc_res(struct bnxt_qplib_res *res, struct pci_dev *pdev, 
			 struct net_device *netdev,

			 struct bnxt_qplib_dev_attr *dev_attr)

{

	int rc = 0;

	int rc;



	res->pdev = pdev;

	res->netdev = netdev;