Commit 13e856b8 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: xilinx: Remove duplicate assignment of of_gpio_n_cells 



The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 3c0c7b1d

drivers/gpio/gpio-xilinx.c

+0 −11
Original line number Diff line number Diff line
@@ -558,7 +558,6 @@ static int xgpio_probe(struct platform_device *pdev) 
	int status = 0;

	struct device_node *np = pdev->dev.of_node;

	u32 is_dual = 0;

	u32 cells = 2;

	u32 width[2];

	u32 state[2];

	u32 dir[2];
@@ -591,15 +590,6 @@ static int xgpio_probe(struct platform_device *pdev) 


	bitmap_from_arr32(chip->dir, dir, 64);



	/* Update cells with gpio-cells value */

	if (of_property_read_u32(np, "#gpio-cells", &cells))

		dev_dbg(&pdev->dev, "Missing gpio-cells property\n");



	if (cells != 2) {

		dev_err(&pdev->dev, "#gpio-cells mismatch\n");

		return -EINVAL;

	}



	/*

	 * Check device node and parent device node for device width

	 * and assume default width of 32
@@ -630,7 +620,6 @@ static int xgpio_probe(struct platform_device *pdev) 
	chip->gc.parent = &pdev->dev;

	chip->gc.direction_input = xgpio_dir_in;

	chip->gc.direction_output = xgpio_dir_out;

	chip->gc.of_gpio_n_cells = cells;

	chip->gc.get = xgpio_get;

	chip->gc.set = xgpio_set;

	chip->gc.request = xgpio_request;