Commit 13bd9014 authored by Dan Aloni's avatar Dan Aloni Committed by Trond Myklebust
Browse files

Revert "SUNRPC: Remove unreachable error condition" 



This reverts commit efe57fd5.

The assumption that it is impossible to return an ERR pointer from
rpc_run_task() no longer holds due to commit 25cf32ad ("SUNRPC:
Handle allocation failure in rpc_new_task()").

Fixes: 25cf32ad ('SUNRPC: Handle allocation failure in rpc_new_task()')
Fixes: efe57fd5 ('SUNRPC: Remove unreachable error condition')
Signed-off-by: default avatarDan Aloni <dan.aloni@vastdata.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent d7a51186

net/sunrpc/clnt.c

+3 −0
Original line number Diff line number Diff line
@@ -2873,6 +2873,9 @@ int rpc_clnt_test_and_add_xprt(struct rpc_clnt *clnt, 


	task = rpc_call_null_helper(clnt, xprt, NULL, RPC_TASK_ASYNC,

			&rpc_cb_add_xprt_call_ops, data);

	if (IS_ERR(task))

		return PTR_ERR(task);



	data->xps->xps_nunique_destaddr_xprts++;

	rpc_put_task(task);

success: