Commit 13a0d108 authored by Yu Liao's avatar Yu Liao Committed by Sebastian Reichel
Browse files

power: supply: qcom_pmi8998_charger: fix uninitialized variable 



smatch warnings:
  drivers/power/supply/qcom_pmi8998_charger.c:565 smb2_status_change_work() error: uninitialized symbol 'usb_online'.

usb_online is used uninitialized whenever smb2_get_prop_usb_online()
returns a negative value.

Thus, fix the issue by initializing usb_online to 0.

Fixes: 8648aeb5 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202307280638.556PrzIS-lkp@intel.com/


Signed-off-by: default avatarYu Liao <liaoyu15@huawei.com>
Reviewed-by: default avatarCaleb Connolly <caleb.connolly@linaro.org>
Link: https://lore.kernel.org/r/20230802023130.2516232-1-liaoyu15@huawei.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent af73fd32

drivers/power/supply/qcom_pmi8998_charger.c

+2 −1
Original line number Diff line number Diff line
@@ -556,7 +556,8 @@ static int smb2_set_current_limit(struct smb2_chip *chip, unsigned int val) 
static void smb2_status_change_work(struct work_struct *work)

{

	unsigned int charger_type, current_ua;

	int usb_online, count, rc;

	int usb_online = 0;

	int count, rc;

	struct smb2_chip *chip;



	chip = container_of(work, struct smb2_chip, status_change_work.work);