Commit 139f46d3 authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

ext4: Remove unnecessary release when memory allocation failed in ext4_mb_init_cache 



If we alloc array of buffer_head failed, there is no resource need to be
freed and we can simpily return error.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20230303172120.3800725-10-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 85b67ffb

fs/ext4/mballoc.c

+2 −4
Original line number Diff line number Diff line
@@ -1168,10 +1168,8 @@ static int ext4_mb_init_cache(struct page *page, char *incore, gfp_t gfp) 
	if (groups_per_page > 1) {

		i = sizeof(struct buffer_head *) * groups_per_page;

		bh = kzalloc(i, gfp);

		if (bh == NULL) {

			err = -ENOMEM;

			goto out;

		}

		if (bh == NULL)

			return -ENOMEM;

	} else

		bh = &bhs;