Commit 13661fc4 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda: Flush pending unsolicited events before suspend 

The HD-audio controller driver processes the unsolicited events via
its work asynchronously, and this might be pending when the system
goes to suspend.  When a lengthy event handling like ELD byte reads is
running, this might trigger unexpected accesses among suspend/resume
procedure, typically seen with Nvidia driver that still requires the
handling via unsolicited event verbs for ELD updates.

This patch adds the flush of unsol_work to assure that pending events
are processed before going into suspend.

Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1182377


Reported-and-tested-by: default avatarAbhishek Sahu <abhsahu@nvidia.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210310112809.9215-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c5aa956e

sound/pci/hda/hda_intel.c

+2 −0
Original line number Diff line number Diff line
@@ -1026,6 +1026,8 @@ static int azx_prepare(struct device *dev) 
	chip = card->private_data;

	chip->pm_prepared = 1;



	flush_work(&azx_bus(chip)->unsol_work);



	/* HDA controller always requires different WAKEEN for runtime suspend

	 * and system suspend, so don't use direct-complete here.

	 */