Commit 135780f1 authored by Luca Weiss's avatar Luca Weiss Committed by Pavel Machek
Browse files

leds: is31fl319x: Fix setting current limit for is31fl319{0,1,3} 



The current setting lives in bits 4:2 (as also defined by the mask) but
the current limit defines in the driver use bits 2:0 which should be
shifted over so they don't get masked out completely (except for 17.5mA
which became 10mA).

Now checking /sys/kernel/debug/regmap/1-0068/registers shows that the
current limit is applied correctly and doesn't take the default b000 =
42mA.

Fixes: fa877cf1 ("leds: is31fl319x: Add support for is31fl319{0,1,3} chips")
Signed-off-by: default avatarLuca Weiss <luca@z3ntu.xyz>
Reviewed-by: default avatarVincent Knecht <vincent.knecht@mailoo.org>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 447242e1

drivers/leds/leds-is31fl319x.c

+2 −1
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ 
#define IS31FL3190_CURRENT_uA_MIN	5000

#define IS31FL3190_CURRENT_uA_DEFAULT	42000

#define IS31FL3190_CURRENT_uA_MAX	42000

#define IS31FL3190_CURRENT_SHIFT	2

#define IS31FL3190_CURRENT_MASK		GENMASK(4, 2)

#define IS31FL3190_CURRENT_5_mA		0x02

#define IS31FL3190_CURRENT_10_mA	0x01
@@ -553,7 +554,7 @@ static int is31fl319x_probe(struct i2c_client *client) 
			     is31fl3196_db_to_gain(is31->audio_gain_db));

	else

		regmap_update_bits(is31->regmap, IS31FL3190_CURRENT, IS31FL3190_CURRENT_MASK,

				   is31fl3190_microamp_to_cs(dev, aggregated_led_microamp));

				   is31fl3190_microamp_to_cs(dev, aggregated_led_microamp) << IS31FL3190_CURRENT_SHIFT);



	for (i = 0; i < is31->cdef->num_leds; i++) {

		struct is31fl319x_led *led = &is31->leds[i];