Commit 1353e576 authored Jul 07, 2022 by Colin Ian King Committed by Herbert Xu Jul 15, 2022

crypto: x86/blowfish - remove redundant assignment to variable nytes



Variable nbytes is being assigned a value that is never read, it is
being re-assigned in the next statement in the while-loop. The
assignment is redundant and can be removed.

Cleans up clang scan-build warnings, e.g.:
arch/x86/crypto/blowfish_glue.c:147:10: warning: Although the value
stored to 'nbytes' is used in the enclosing expression, the value
is never actually read from 'nbytes'

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent b77e34f5

arch/x86/crypto/blowfish_glue.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -144,7 +144,7 @@ static int cbc_encrypt(struct skcipher_request *req)

		err = skcipher_walk_virt(&walk, req, false);

		while ((nbytes = walk.nbytes)) {
		while (walk.nbytes) {
		nbytes = __cbc_encrypt(ctx, &walk);
		err = skcipher_walk_done(&walk, nbytes);
		}
		@@ -225,7 +225,7 @@ static int cbc_decrypt(struct skcipher_request *req)

		err = skcipher_walk_virt(&walk, req, false);

		while ((nbytes = walk.nbytes)) {
		while (walk.nbytes) {
		nbytes = __cbc_decrypt(ctx, &walk);
		err = skcipher_walk_done(&walk, nbytes);
		}