Commit 1351f1d1 authored by Wolfram Sang's avatar Wolfram Sang Committed by Hans de Goede
Browse files

platform/x86: samsung-laptop: set debugfs blobs to read only 



Those blobs can only be read. So, don't confuse users with 'writable'
flags. Also, remove S_IFREG because debugfs takes care of that.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20210517100746.29663-2-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 5b6a9a2f

drivers/platform/x86/samsung-laptop.c

+4 −4
Original line number Diff line number Diff line
@@ -1296,12 +1296,12 @@ static void samsung_debugfs_init(struct samsung_laptop *samsung) 
	debugfs_create_u32("d1", 0644, root, &samsung->debug.data.d1);

	debugfs_create_u16("d2", 0644, root, &samsung->debug.data.d2);

	debugfs_create_u8("d3", 0644, root, &samsung->debug.data.d3);

	debugfs_create_blob("data", 0644, root, &samsung->debug.data_wrapper);

	debugfs_create_blob("f0000_segment", 0600, root,

	debugfs_create_blob("data", 0444, root, &samsung->debug.data_wrapper);

	debugfs_create_blob("f0000_segment", 0400, root,

			    &samsung->debug.f0000_wrapper);

	debugfs_create_file("call", S_IFREG | 0444, root, samsung,

	debugfs_create_file("call", 0444, root, samsung,

			    &samsung_laptop_call_fops);

	debugfs_create_blob("sdiag", 0644, root, &samsung->debug.sdiag_wrapper);

	debugfs_create_blob("sdiag", 0444, root, &samsung->debug.sdiag_wrapper);

}



static void samsung_sabi_exit(struct samsung_laptop *samsung)