Commit 134f49de authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

serial: 8250_tegra: Fix an error handling path in tegra_uart_probe() 



If an error occurs after reset_control_deassert(), it must be re-asserted,
as already done in the .remove() function.

Fixes: c6825c63 ("serial: 8250_tegra: Create Tegra specific 8250 driver")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/f8130f35339cc80edc6b9aac4bb2a60b60a226bf.1684063511.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 44c026a7

drivers/tty/serial/8250/8250_tegra.c

+3 −1
Original line number Diff line number Diff line
@@ -113,13 +113,15 @@ static int tegra_uart_probe(struct platform_device *pdev) 


	ret = serial8250_register_8250_port(&port8250);

	if (ret < 0)

		goto err_clkdisable;

		goto err_ctrl_assert;



	platform_set_drvdata(pdev, uart);

	uart->line = ret;



	return 0;



err_ctrl_assert:

	reset_control_assert(uart->rst);

err_clkdisable:

	clk_disable_unprepare(uart->clk);