Commit 13462ba1 authored by Tom Rix's avatar Tom Rix Committed by Alexandre Belloni
Browse files

i3c: master: dw: check return of dw_i3c_master_get_free_pos() 



Clang static analysis reports this problem
dw-i3c-master.c:799:9: warning: The result of the left shift is
  undefined because the left operand is negative
                      COMMAND_PORT_DEV_INDEX(pos) |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

pos can be negative because dw_i3c_master_get_free_pos() can return an
error.  So check for an error.

Fixes: 1dd728f5 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com
parent 7a2bccd1

drivers/i3c/master/dw-i3c-master.c

+4 −0
Original line number Diff line number Diff line
@@ -793,6 +793,10 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m) 
		return -ENOMEM;



	pos = dw_i3c_master_get_free_pos(master);

	if (pos < 0) {

		dw_i3c_master_free_xfer(xfer);

		return pos;

	}

	cmd = &xfer->cmds[0];

	cmd->cmd_hi = 0x1;

	cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |