Commit 133da4b4 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: host: xhci: drop redundant checks 



In xhci_endpoint_{disable|reset}() the expression '&vdev->eps[ep_index]'
just cannot be NULL, so the checks have no sense at all...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20220216095153.1303105-9-mathias.nyman@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cd36facf

drivers/usb/host/xhci.c

+0 −4
Original line number Diff line number Diff line
@@ -3150,8 +3150,6 @@ static void xhci_endpoint_disable(struct usb_hcd *hcd, 


	ep_index = xhci_get_endpoint_index(&host_ep->desc);

	ep = &vdev->eps[ep_index];

	if (!ep)

		goto done;



	/* wait for hub_tt_work to finish clearing hub TT */

	if (ep->ep_state & EP_CLEARING_TT) {
@@ -3209,8 +3207,6 @@ static void xhci_endpoint_reset(struct usb_hcd *hcd, 
		return;

	ep_index = xhci_get_endpoint_index(&host_ep->desc);

	ep = &vdev->eps[ep_index];

	if (!ep)

		return;



	/* Bail out if toggle is already being cleared by a endpoint reset */

	spin_lock_irqsave(&xhci->lock, flags);