Commit 13251ce1 authored by 蒋家盛's avatar 蒋家盛 Committed by Benjamin Tissoires
Browse files

HID: potential dereference of null pointer 



The return value of devm_kzalloc() needs to be checked.
To avoid hdev->dev->driver_data to be null in case of the failure of
alloc.

Fixes: 14c9c014 ("HID: add vivaldi HID driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20211215083605.117638-1-jiasheng@iscas.ac.cn
parent 93a2207c

drivers/hid/hid-vivaldi.c

+3 −0
Original line number Diff line number Diff line
@@ -57,6 +57,9 @@ static int vivaldi_probe(struct hid_device *hdev, 
	int ret;



	drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);

	if (!drvdata)

		return -ENOMEM;



	hid_set_drvdata(hdev, drvdata);



	ret = hid_parse(hdev);