Commit 131b0edc authored by Mitch Williams's avatar Mitch Williams Committed by Tony Nguyen
Browse files

iavf: validate pointers 



In some cases, the ethtool get_rxfh handler may be called with a null
key or indir parameter. So check these pointers, or you will have a very
bad day.

Fixes: 43a3d9ba ("i40evf: Allow PF driver to configure RSS")
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Tested-by: default avatarTony Brelinski <tony.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 4f040080

drivers/net/ethernet/intel/iavf/iavf_ethtool.c

+6 −7
Original line number Diff line number Diff line
@@ -1859,11 +1859,10 @@ static int iavf_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key, 


	if (hfunc)

		*hfunc = ETH_RSS_HASH_TOP;

	if (!indir)

		return 0;



	if (key)

		memcpy(key, adapter->rss_key, adapter->rss_key_size);



	if (indir)

		/* Each 32 bits pointed by 'indir' is stored with a lut entry */

		for (i = 0; i < adapter->rss_lut_size; i++)

			indir[i] = (u32)adapter->rss_lut[i];