Commit 1314e122 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Greg Kroah-Hartman
Browse files

misc: tps6594: Remove redundant dev_err_probe() for platform_get_irq_byname() 



There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230807093010.2112302-1-ruanjinjie@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd06978b

drivers/misc/tps6594-esm.c

+1 −2
Original line number Diff line number Diff line
@@ -39,8 +39,7 @@ static int tps6594_esm_probe(struct platform_device *pdev) 
	for (i = 0 ; i < pdev->num_resources ; i++) {

		irq = platform_get_irq_byname(pdev, pdev->resource[i].name);

		if (irq < 0)

			return dev_err_probe(dev, irq, "Failed to get %s irq\n",

					     pdev->resource[i].name);

			return irq;



		ret = devm_request_threaded_irq(dev, irq, NULL,

						tps6594_esm_isr, IRQF_ONESHOT,

drivers/misc/tps6594-pfsm.c

+1 −2
Original line number Diff line number Diff line
@@ -266,8 +266,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev) 
	for (i = 0 ; i < pdev->num_resources ; i++) {

		irq = platform_get_irq_byname(pdev, pdev->resource[i].name);

		if (irq < 0)

			return dev_err_probe(dev, irq, "Failed to get %s irq\n",

					     pdev->resource[i].name);

			return irq;



		ret = devm_request_threaded_irq(dev, irq, NULL,

						tps6594_pfsm_isr, IRQF_ONESHOT,