Commit 130aebe1 authored by Jianglei Nie's avatar Jianglei Nie Committed by Zheng Zengkai
Browse files

RDMA/hfi1: fix potential memory leak in setup_base_ctxt() 

stable inclusion
from stable-v5.10.137
commit a85c7dd1edadcdeca24e603a6618153a3bcc81ca
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I60PLB

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a85c7dd1edadcdeca24e603a6618153a3bcc81ca

--------------------------------

[ Upstream commit aa2a1df3 ]

setup_base_ctxt() allocates a memory chunk for uctxt->groups with
hfi1_alloc_ctxt_rcv_groups(). When init_user_ctxt() fails, uctxt->groups
is not released, which will lead to a memory leak.

We should release the uctxt->groups with hfi1_free_ctxt_rcv_groups()
when init_user_ctxt() fails.

Fixes: e87473bc ("IB/hfi1: Only set fd pointer when base context is completely initialized")
Link: https://lore.kernel.org/r/20220711070718.2318320-1-niejianglei2021@163.com


Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Acked-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: default avatarWei Li <liwei391@huawei.com>
parent 37ecf2fe

drivers/infiniband/hw/hfi1/file_ops.c

+3 −1
Original line number Diff line number Diff line
@@ -1220,8 +1220,10 @@ static int setup_base_ctxt(struct hfi1_filedata *fd, 
		goto done;



	ret = init_user_ctxt(fd, uctxt);

	if (ret)

	if (ret) {

		hfi1_free_ctxt_rcv_groups(uctxt);

		goto done;

	}



	user_init(uctxt);