Commit 12f1dbcf authored by Miaohe Lin's avatar Miaohe Lin Committed by Andrew Morton
Browse files

mm, hwpoison: fix extra put_page() in soft_offline_page() 

When hwpoison_filter() refuses to soft offline a page, the page refcnt
incremented previously by MF_COUNT_INCREASED would have been consumed via
get_hwpoison_page() if ret <= 0.  So the put_ref_page() here will put the
extra one.  Remove it to fix the issue.

Link: https://lkml.kernel.org/r/20220818130016.45313-4-linmiaohe@huawei.com


Fixes: 9113eaf3 ("mm/memory-failure.c: add hwpoison_filter for soft offline")
Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Acked-by: default avatarNaoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 6bbabd04

mm/memory-failure.c

+0 −2
Original line number Diff line number Diff line
@@ -2591,8 +2591,6 @@ int soft_offline_page(unsigned long pfn, int flags) 
	if (hwpoison_filter(page)) {

		if (ret > 0)

			put_page(page);

		else

			put_ref_page(ref_page);



		mutex_unlock(&mf_mutex);

		return -EOPNOTSUPP;