Commit 12c7d0ae authored by Rob Herring's avatar Rob Herring Committed by Dmitry Torokhov
Browse files

Input: Use of_property_read_bool() for boolean properties 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to of_property_read_bool().

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144708.1542751-1-robh@kernel.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent d26a3a6c

drivers/input/keyboard/matrix_keypad.c

+2 −4
Original line number Diff line number Diff line
@@ -425,14 +425,12 @@ matrix_keypad_parse_dt(struct device *dev) 
		return ERR_PTR(-EINVAL);

	}



	if (of_get_property(np, "linux,no-autorepeat", NULL))

		pdata->no_autorepeat = true;

	pdata->no_autorepeat = of_property_read_bool(np, "linux,no-autorepeat");



	pdata->wakeup = of_property_read_bool(np, "wakeup-source") ||

			of_property_read_bool(np, "linux,wakeup"); /* legacy */



	if (of_get_property(np, "gpio-activelow", NULL))

		pdata->active_low = true;

	pdata->active_low = of_property_read_bool(np, "gpio-activelow");



	pdata->drive_inactive_cols =

		of_property_read_bool(np, "drive-inactive-cols");

drivers/input/keyboard/omap4-keypad.c

+1 −2
Original line number Diff line number Diff line
@@ -274,8 +274,7 @@ static int omap4_keypad_parse_dt(struct device *dev, 
	if (err)

		return err;



	if (of_get_property(np, "linux,input-no-autorepeat", NULL))

		keypad_data->no_autorepeat = true;

	keypad_data->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat");



	return 0;

}

drivers/input/keyboard/samsung-keypad.c

+1 −2
Original line number Diff line number Diff line
@@ -291,8 +291,7 @@ samsung_keypad_parse_dt(struct device *dev) 
		*keymap++ = KEY(row, col, key_code);

	}



	if (of_get_property(np, "linux,input-no-autorepeat", NULL))

		pdata->no_autorepeat = true;

	pdata->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat");



	pdata->wakeup = of_property_read_bool(np, "wakeup-source") ||

			/* legacy name */

drivers/input/keyboard/tegra-kbc.c

+1 −2
Original line number Diff line number Diff line
@@ -504,8 +504,7 @@ static int tegra_kbc_parse_dt(struct tegra_kbc *kbc) 
	if (!of_property_read_u32(np, "nvidia,repeat-delay-ms", &prop))

		kbc->repeat_cnt = prop;



	if (of_find_property(np, "nvidia,needs-ghost-filter", NULL))

		kbc->use_ghost_filter = true;

	kbc->use_ghost_filter = of_property_present(np, "nvidia,needs-ghost-filter");



	if (of_property_read_bool(np, "wakeup-source") ||

	    of_property_read_bool(np, "nvidia,wakeup-source")) /* legacy */