Commit 12c3dca2 authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

ARM: ep93xx: remove MaverickCrunch support 

The MaverickCrunch support for ep93xx never made it into glibc and
was removed from gcc in its 4.8 release in 2012. It is now one of
the last parts of arch/arm/ that fails to build with the clang
integrated assembler, which is unlikely to ever want to support it.

The two alternatives are to force the use of binutils/gas when
building the crunch support, or to remove it entirely.

According to Hartley Sweeten:

 "Martin Guy did a lot of work trying to get the maverick crunch working
  but I was never able to successfully use it for anything. It "kind"
  of works but depending on the EP93xx silicon revision there are still
  a number of hardware bugs that either give imprecise or garbage results.

  I have no problem with removing the kernel support for the maverick
  crunch."

Unless someone else comes up with a good reason to keep it around,
remove it now. This touches mostly the ep93xx platform, but removes
a bit of code from ARM common ptrace and signal frame handling as well.

If there are remaining users of MaverickCrunch, they can use LTS
kernels for at least another five years before kernel support ends.

Link: https://lore.kernel.org/linux-arm-kernel/20210802141245.1146772-1-arnd@kernel.org/
Link: https://lore.kernel.org/linux-arm-kernel/20210226164345.3889993-1-arnd@kernel.org/
Link: https://github.com/ClangBuiltLinux/linux/issues/1272
Link: https://gcc.gnu.org/legacy-ml/gcc/2008-03/msg01063.html


Cc: "Martin Guy" <martinwguy@martinwguy@gmail.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent c500bee1

arch/arm/configs/ep93xx_defconfig

+0 −1
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ CONFIG_MODULE_FORCE_UNLOAD=y 
# CONFIG_BLK_DEV_BSG is not set

CONFIG_PARTITION_ADVANCED=y

CONFIG_ARCH_EP93XX=y

CONFIG_CRUNCH=y

CONFIG_MACH_ADSSPHERE=y

CONFIG_MACH_EDB9301=y

CONFIG_MACH_EDB9302=y

arch/arm/include/asm/fpstate.h

+0 −8
Original line number Diff line number Diff line
@@ -77,14 +77,6 @@ union fp_state { 


#define FP_SIZE (sizeof(union fp_state) / sizeof(int))



struct crunch_state {

	unsigned int	mvdx[16][2];

	unsigned int	mvax[4][3];

	unsigned int	dspsc[2];

};



#define CRUNCH_SIZE	sizeof(struct crunch_state)



#endif



#endif

arch/arm/include/asm/thread_info.h

+0 −8
Original line number Diff line number Diff line
@@ -65,9 +65,6 @@ struct thread_info { 
	__u32			syscall;	/* syscall number */

	__u8			used_cp[16];	/* thread used copro */

	unsigned long		tp_value[2];	/* TLS registers */

#ifdef CONFIG_CRUNCH

	struct crunch_state	crunchstate;

#endif

	union fp_state		fpstate __attribute__((aligned(8)));

	union vfp_state		vfpstate;

#ifdef CONFIG_ARM_THUMBEE
@@ -107,11 +104,6 @@ static inline struct thread_info *current_thread_info(void) 
	((unsigned long)(task_thread_info(tsk)->cpu_context.r7))

#endif



extern void crunch_task_disable(struct thread_info *);

extern void crunch_task_copy(struct thread_info *, void *);

extern void crunch_task_restore(struct thread_info *, void *);

extern void crunch_task_release(struct thread_info *);



extern void iwmmxt_task_disable(struct thread_info *);

extern void iwmmxt_task_copy(struct thread_info *, void *);

extern void iwmmxt_task_restore(struct thread_info *, void *);

arch/arm/include/asm/ucontext.h

+0 −14
Original line number Diff line number Diff line
@@ -43,17 +43,6 @@ struct ucontext { 
 */

#define DUMMY_MAGIC		0xb0d9ed01



#ifdef CONFIG_CRUNCH

#define CRUNCH_MAGIC		0x5065cf03

#define CRUNCH_STORAGE_SIZE	(CRUNCH_SIZE + 8)



struct crunch_sigframe {

	unsigned long	magic;

	unsigned long	size;

	struct crunch_state	storage;

} __attribute__((__aligned__(8)));

#endif



#ifdef CONFIG_IWMMXT

/* iwmmxt_area is 0x98 bytes long, preceded by 8 bytes of signature */

#define IWMMXT_MAGIC		0x12ef842a
@@ -92,9 +81,6 @@ struct vfp_sigframe 
 * one of these.

 */

struct aux_sigframe {

#ifdef CONFIG_CRUNCH

	struct crunch_sigframe	crunch;

#endif

#ifdef CONFIG_IWMMXT

	struct iwmmxt_sigframe	iwmmxt;

#endif

arch/arm/include/uapi/asm/hwcap.h

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
#define HWCAP_EDSP	(1 << 7)

#define HWCAP_JAVA	(1 << 8)

#define HWCAP_IWMMXT	(1 << 9)

#define HWCAP_CRUNCH	(1 << 10)

#define HWCAP_CRUNCH	(1 << 10)	/* Obsolete */

#define HWCAP_THUMBEE	(1 << 11)

#define HWCAP_NEON	(1 << 12)

#define HWCAP_VFPv3	(1 << 13)