Commit 12c0285f authored by Boris Burkov's avatar Boris Burkov Committed by Peng Zhang
Browse files

btrfs: free qgroup reserve when ORDERED_IOERR is set 

stable inclusion
from stable-v6.6.8
commit 14570dfa170ede01eacedc60f717df121d8b9bbd
bugzilla: https://gitee.com/openeuler/kernel/issues/I99K53

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=14570dfa170ede01eacedc60f717df121d8b9bbd



--------------------------------

commit f63e1164b90b385cd832ff0fdfcfa76c3cc15436 upstream.

An ordered extent completing is a critical moment in qgroup reserve
handling, as the ownership of the reservation is handed off from the
ordered extent to the delayed ref. In the happy path we release (unlock)
but do not free (decrement counter) the reservation, and the delayed ref
drives the free. However, on an error, we don't create a delayed ref,
since there is no ref to add. Therefore, free on the error path.

CC: stable@vger.kernel.org # 6.1+
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
parent 114a544c

fs/btrfs/ordered-data.c

+3 −1
Original line number Diff line number Diff line
@@ -603,7 +603,9 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode, 
			release = entry->disk_num_bytes;

		else

			release = entry->num_bytes;

		btrfs_delalloc_release_metadata(btrfs_inode, release, false);

		btrfs_delalloc_release_metadata(btrfs_inode, release,

						test_bit(BTRFS_ORDERED_IOERR,

							 &entry->flags));

	}



	percpu_counter_add_batch(&fs_info->ordered_bytes, -entry->num_bytes,