Commit 12aece8b authored by Zheng Wang's avatar Zheng Wang Committed by David S. Miller
Browse files

eth: sp7021: fix use after free bug in spl2sw_nvmem_get_mac_address 



This frees "mac" and tries to display its address as part of the error
message on the next line.  Swap the order.

Fixes: fd3040b9 ("net: ethernet: Add driver for Sunplus SP7021")
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b43f9acb

drivers/net/ethernet/sunplus/spl2sw_driver.c

+1 −1
Original line number Diff line number Diff line
@@ -248,8 +248,8 @@ static int spl2sw_nvmem_get_mac_address(struct device *dev, struct device_node * 


	/* Check if mac address is valid */

	if (!is_valid_ether_addr(mac)) {

		kfree(mac);

		dev_info(dev, "Invalid mac address in nvmem (%pM)!\n", mac);

		kfree(mac);

		return -EINVAL;

	}