Commit 12aae8f1 authored by Bruce Allan's avatar Bruce Allan Committed by Tony Nguyen
Browse files

ice: remove dead code 



The check for a NULL pf pointer is moot since the earlier declaration and
assignment of struct device *dev already de-referenced the pointer.  Also,
the only caller of ice_set_dflt_mib() already ensures pf is not NULL.

Cc: Dave Ertman <david.m.ertman@intel.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 11404310

drivers/net/ethernet/intel/ice/ice_main.c

+1 −7
Original line number Diff line number Diff line
@@ -785,15 +785,9 @@ static void ice_set_dflt_mib(struct ice_pf *pf) 
	u8 mib_type, *buf, *lldpmib = NULL;

	u16 len, typelen, offset = 0;

	struct ice_lldp_org_tlv *tlv;

	struct ice_hw *hw;

	struct ice_hw *hw = &pf->hw;

	u32 ouisubtype;



	if (!pf) {

		dev_dbg(dev, "%s NULL pf pointer\n", __func__);

		return;

	}



	hw = &pf->hw;

	mib_type = SET_LOCAL_MIB_TYPE_LOCAL_MIB;

	lldpmib = kzalloc(ICE_LLDPDU_SIZE, GFP_KERNEL);

	if (!lldpmib) {