Commit 12a4d677 authored by Wan Jiabing's avatar Wan Jiabing Committed by Jakub Kicinski
Browse files

net: phy: micrel: Fix incorrect variable type in micrel 



In lanphy_read_page_reg, calling __phy_read() might return a negative
error code. Use 'int' to check the error code.

Fixes: 7c2dcfa2 ("net: phy: micrel: Add support for LAN8804 PHY")
Signed-off-by: default avatarWan Jiabing <wanjiabing@vivo.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220509144519.2343399-1-wanjiabing@vivo.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dc5306a8

drivers/net/phy/micrel.c

+2 −3
Original line number Diff line number Diff line
@@ -1743,7 +1743,7 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev, 


static int lanphy_read_page_reg(struct phy_device *phydev, int page, u32 addr)

{

	u32 data;

	int data;



	phy_lock_mdio_bus(phydev);

	__phy_write(phydev, LAN_EXT_PAGE_ACCESS_CONTROL, page);
@@ -2444,8 +2444,7 @@ static int lan8804_config_init(struct phy_device *phydev) 


static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev)

{

	u16 tsu_irq_status;

	int irq_status;

	int irq_status, tsu_irq_status;



	irq_status = phy_read(phydev, LAN8814_INTS);

	if (irq_status > 0 && (irq_status & LAN8814_INT_LINK))