Unverified Commit 1294d7d7 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: codecs: rt1316-sdw: simplify set_stream 



Using a dynamic allocation to store a single pointer is not very
efficient/useful.

Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.

And last the API requires the previous stream information to be
cleared when the argument is NULL.

Simplify the code to address all 3 problems.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-6-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ce8ffc1b

sound/soc/codecs/rt1316-sdw.c

+7 −23
Original line number Diff line number Diff line
@@ -494,19 +494,7 @@ static const struct snd_soc_dapm_route rt1316_dapm_routes[] = { 
static int rt1316_set_sdw_stream(struct snd_soc_dai *dai, void *sdw_stream,

				int direction)

{

	struct sdw_stream_data *stream;



	if (!sdw_stream)

		return 0;



	stream = kzalloc(sizeof(*stream), GFP_KERNEL);

	if (!stream)

		return -ENOMEM;



	stream->sdw_stream = sdw_stream;



	/* Use tx_mask or rx_mask to configure stream tag and set dma_data */

	snd_soc_dai_dma_data_set(dai, direction, stream);

	snd_soc_dai_dma_data_set(dai, direction, sdw_stream);



	return 0;

}
@@ -514,11 +502,7 @@ static int rt1316_set_sdw_stream(struct snd_soc_dai *dai, void *sdw_stream, 
static void rt1316_sdw_shutdown(struct snd_pcm_substream *substream,

				struct snd_soc_dai *dai)

{

	struct sdw_stream_data *stream;



	stream = snd_soc_dai_get_dma_data(dai, substream);

	snd_soc_dai_set_dma_data(dai, substream, NULL);

	kfree(stream);

}



static int rt1316_sdw_hw_params(struct snd_pcm_substream *substream,
@@ -529,13 +513,13 @@ static int rt1316_sdw_hw_params(struct snd_pcm_substream *substream, 
		snd_soc_component_get_drvdata(component);

	struct sdw_stream_config stream_config = {0};

	struct sdw_port_config port_config = {0};

	struct sdw_stream_data *stream;

	struct sdw_stream_runtime *sdw_stream;

	int retval;



	dev_dbg(dai->dev, "%s %s", __func__, dai->name);

	stream = snd_soc_dai_get_dma_data(dai, substream);

	sdw_stream = snd_soc_dai_get_dma_data(dai, substream);



	if (!stream)

	if (!sdw_stream)

		return -EINVAL;



	if (!rt1316->sdw_slave)
@@ -551,7 +535,7 @@ static int rt1316_sdw_hw_params(struct snd_pcm_substream *substream, 
		port_config.num = 2;



	retval = sdw_stream_add_slave(rt1316->sdw_slave, &stream_config,

				&port_config, 1, stream->sdw_stream);

				&port_config, 1, sdw_stream);

	if (retval) {

		dev_err(dai->dev, "Unable to configure port\n");

		return retval;
@@ -566,13 +550,13 @@ static int rt1316_sdw_pcm_hw_free(struct snd_pcm_substream *substream, 
	struct snd_soc_component *component = dai->component;

	struct rt1316_sdw_priv *rt1316 =

		snd_soc_component_get_drvdata(component);

	struct sdw_stream_data *stream =

	struct sdw_stream_runtime *sdw_stream =

		snd_soc_dai_get_dma_data(dai, substream);



	if (!rt1316->sdw_slave)

		return -EINVAL;



	sdw_stream_remove_slave(rt1316->sdw_slave, stream->sdw_stream);

	sdw_stream_remove_slave(rt1316->sdw_slave, sdw_stream);

	return 0;

}

sound/soc/codecs/rt1316-sdw.h

+0 −4
Original line number Diff line number Diff line
@@ -50,8 +50,4 @@ struct rt1316_sdw_priv { 
	unsigned int bq_params_cnt;

};



struct sdw_stream_data {

	struct sdw_stream_runtime *sdw_stream;

};



#endif /* __RT1316_SDW_H__ */