Commit 12929198 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Jakub Kicinski
Browse files

net: sched: Use struct_size() helper in kvmalloc() 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows
that, in the worst scenario, could lead to heap overflows.

Link: https://github.com/KSPP/linux/issues/160


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210929201718.GA342296@embeddedor


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dd9a887b

net/sched/sch_netem.c

+1 −1
Original line number Diff line number Diff line
@@ -785,7 +785,7 @@ static int get_dist_table(struct Qdisc *sch, struct disttable **tbl, 
	if (!n || n > NETEM_DIST_MAX)

		return -EINVAL;



	d = kvmalloc(sizeof(struct disttable) + n * sizeof(s16), GFP_KERNEL);

	d = kvmalloc(struct_size(d, table, n), GFP_KERNEL);

	if (!d)

		return -ENOMEM;