Unverified Commit 11fd6d8e authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mark Brown
Browse files

ASoC: SOF: fix debugfs initialisation error handling 



If debugfs initialisation fails partially in sof_probe_continue() some
debugfs files and the root directory might have been created
successfully. They have to be cleaned up if some of them failed too.

Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarXiuli Pan <xiulipan@outlook.com>
Signed-off-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210315163932.18663-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 54d796b8

sound/soc/sof/core.c

+3 −2
Original line number Diff line number Diff line
@@ -154,7 +154,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev) 
	if (ret < 0) {

		dev_err(sdev->dev, "error: failed to get machine info %d\n",

			ret);

		goto dbg_err;

		goto dsp_err;

	}



	/* set up platform component driver */
@@ -257,8 +257,9 @@ static int sof_probe_continue(struct snd_sof_dev *sdev) 
fw_load_err:

	snd_sof_ipc_free(sdev);

ipc_err:

	snd_sof_free_debug(sdev);

dbg_err:

	snd_sof_free_debug(sdev);

dsp_err:

	snd_sof_remove(sdev);



	/* all resources freed, update state to match */