Commit 11e94d2b authored by Tom Rix's avatar Tom Rix Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: initialize seq variable 



Clang static analysis reports this issue
d3.c:567:22: warning: The left operand of '>' is
  a garbage value
  if (seq.tkip.iv32 > cur_rx_iv32)
      ~~~~~~~~~~~~~ ^

seq is never initialized. Call ieee80211_get_key_rx_seq() to
initialize seq.

Fixes: 0419e5e6 ("iwlwifi: mvm: d3: separate TKIP data from key iteration")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230414130637.6dd372f84f93.If1f708c90e6424a935b4eba3917dfb7582e0dd0a@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 5f10705e

drivers/net/wireless/intel/iwlwifi/mvm/d3.c

+1 −0
Original line number Diff line number Diff line
@@ -564,6 +564,7 @@ static void iwl_mvm_wowlan_get_tkip_data(struct ieee80211_hw *hw, 
		}



		for (i = 0; i < IWL_NUM_RSC; i++) {

			ieee80211_get_key_rx_seq(key, i, &seq);

			/* wrapping isn't allowed, AP must rekey */

			if (seq.tkip.iv32 > cur_rx_iv32)

				cur_rx_iv32 = seq.tkip.iv32;