Commit 11e0e167 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: meson: add missing allocation failure check on new_buf 



Currently if the allocation of new_buf fails then a null pointer
dereference occurs when assiging new_buf->vb. Avoid this by returning
early on a memory allocation failure as there is not much more can
be done at this point.

Addresses-Coverity: ("Dereference null return")

Fixes: 3e7f51bd ("media: meson: add v4l2 m2m video decoder driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarKevin Hilman <khilman@baylibre.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 55f240a2

drivers/staging/media/meson/vdec/vdec.c

+2 −0
Original line number Diff line number Diff line
@@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb) 
	struct amvdec_buffer *new_buf;



	new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);

	if (!new_buf)

		return;

	new_buf->vb = vb;



	mutex_lock(&sess->bufs_recycle_lock);